Ship the disk templates zstd-compressed and expand them to sparse files on first use - #771
Merged
Merged
Conversation
…es on first use, so releases no longer carry a 20 GiB sparse member that GNU tar cannot read
… native Windows test job
…ge-template # Conflicts: # lib/libkrun.dylib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 20 GiB storage template holds ~650 KiB of real data, and shipping it as a sparse file meant releases depended on tar sparse-encoding interop that GNU tar rejects on macOS-built tarballs and that Nix materializes in full; shipping the compressed bytes instead removes the sparse member entirely and the engine restores the sparse file on first use.